[chore] Update documentation in query_service.proto
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 478 478
=========================================
Hits 478 478 ☔ View full report in Codecov by Sentry. |
mahadzaryab1
changed the title
query_service.proto to bring documentation up to datequery_service.proto
yurishkuro
reviewed
Feb 17, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Feb 17, 2025
yurishkuro
reviewed
Feb 17, 2025
yurishkuro
reviewed
Feb 17, 2025
proto/api_v3/query_service.proto
Outdated
| string service_name = 1; | ||
|
|
||
| // `operation_name` filters traces generated by a specific operation. |
There was a problem hiding this comment.
Suggested change
| // `operation_name` filters traces generated by a specific operation. | |
| // `operation_name` filters spans by a specific operation / span name. |
There was a problem hiding this comment.
we could rename this to span_name, to match OTLP more closely. "operation" it not a term in OTEL.
There was a problem hiding this comment.
@yurishkuro For the rename, I assume you mean for remote storage api v2?
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
query_service.prototo improve the documentation so that it can be re-used for the remote storage API v2How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test