Open
Conversation
sujalshah-bit
force-pushed
the
add-dependencies-api
branch
from
57baf75 to
7460204
Compare
4 tasks
sujalshah-bit
force-pushed
the
add-dependencies-api
branch
from
7460204 to
0907ff6
Compare
Add the GetDependencies RPC endpoint to enable querying service dependencies within a specified time window. This includes: - GetDependenciesRequest with end_time and lookback parameters - GetDependenciesResponse with DependencyLink message - HTTP GET mapping to /api/v3/dependencies endpoint Signed-off-by: Sujal Shah <sujalshah28092004@gmail.com>
sujalshah-bit
force-pushed
the
add-dependencies-api
branch
from
0907ff6 to
b2fbf17
Compare
Author
|
@yurishkuro Could you kindly review this one :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 422 422
=========================================
Hits 422 422 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Partly Fixes 7595.
Description of the changes
GetDependenciesRPC endpoint to Query Service API v3GetDependenciesRequestmessage withend_timeandlookbackparametersGetDependenciesResponsemessage with repeatedDependencyLinkentriesDependencyLinkmessage to represent parent-child service relationships with call counts/api/v3/dependenciesendpointHow was this change tested?
jaeger related PR
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test