Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/migrate page ,index and TraceIdSearch to functional component #2673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat/migrate page ,index and TraceIdSearch to functional component #2673

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e834cce
migrate page index and traceidsearch to functional comp
Mubashirshariq Feb 18, 2025
87e41f9
added configuration steps inside effect
Mubashirshariq Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/jaeger-ui/src/components/App/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ const jaegerTheme = {
},
};

// Initialize API and process scripts
JaegerAPI.apiRoot = DEFAULT_API_ROOT;
processScripts();

const JaegerUIApp = () => {
useEffect(() => {
JaegerAPI.apiRoot = DEFAULT_API_ROOT;
processScripts();
}, []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useEffect runs after the component mounts initially, while constructors are executed before the component mounts.
A better alternative would be to use a custom hook that uses a ref/state to keep track of the functional. Read a nice article here that explains why functional components lack this constructor alternative and what should be the workaround.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but i think here it needs to be inside the useEffect since processScripts() directly interacts with DOM,so it should be rendered every time the component is mounted

return (
<ConfigProvider theme={jaegerTheme}>
<Provider store={store}>
Expand Down