Fix/removed snapshot tests in operation details table #2674
Conversation
Signed-off-by: Mubashirshariq <[email protected]>
Signed-off-by: Mubashirshariq <[email protected]>
Signed-off-by: Mubashirshariq <[email protected]>
Mubashirshariq
requested review from
mahadzaryab1
and removed request for
a team
packages/jaeger-ui/src/setupTests.js
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import '@testing-library/jest-dom'; |
There was a problem hiding this comment.
Tobeindocument doesn't work unless we add setupTests.js.
refer this
There was a problem hiding this comment.
we already have tests that use this function without any new dependencies or setup step
packages/jaeger-ui/src/components/common/ErrorMessage.test.js
51: expect(screen.getByTestId('ErrorMessage--details--wrapper')).toBeInTheDocument();
package.json
Outdated
| "dependencies": { | ||
| "@testing-library/jest-dom": "^6.6.3", | ||
| "@testing-library/react": "^16.2.0", | ||
| "@testing-library/user-event": "^14.6.1" |
There was a problem hiding this comment.
these are not runtime dependencies
There was a problem hiding this comment.
Earlier i added them as dev dependencies but the n npm run lint started to complain to add it to dependencies rather than dev dependency
There was a problem hiding this comment.
will run lint again,will try to add them to devdependencies
Signed-off-by: Mubashirshariq <[email protected]>
|
@yurishkuro i have moved RTL to dev dependencies but the issue i am getting running while |
|
@Mubashirshariq You are trying to install the dependencies in project's root. They need to be in the respective workspace, i.e., |
@hari45678 yeah i also figured it out now only |
Which problem is this PR solving?
Resolves #2659
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test