-
Notifications
You must be signed in to change notification settings - Fork 595
feat: Add incomplete trace detection and adjustable search time offset #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add incomplete trace detection and adjustable search time offset #3206
Conversation
|
@yurishkuro, may I get your review on this? |
|
f238ea6 to
09c8da2
Compare
|
@yurishkuro rebased and updated the pr description with the required screenshots, Thanks! |
|
thanks for the screenshots. I would like two changes:
|
c3cca6f to
f5ca93a
Compare
|
@yurishkuro updated the code and screenshots in the description with you requested changes. Thanks. |
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.css
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.tsx
Outdated
Show resolved
Hide resolved
a7ac25b to
776d0aa
Compare
|
Can we make "Adjusted -1m" to appear on the same line as Lookback label, only flushed right? The form already has the Go button below the fold on my screen, we don't want to make it longer. |
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.css
Outdated
Show resolved
Hide resolved
a6e651c to
b916dd3
Compare
detection and adjustable search time offset Signed-off-by: Snowiee <[email protected]>
b916dd3 to
82aea86
Compare
|
@yurishkuro updated, Thanks! |
Which problem is this PR solving?
Description of the changes
non-existent parent spans (indicating potentially incomplete traces)
hasOrphanSpansandorphanSpanCountfields to the Trace typeorphan spans
search.adjustTimeconfig option that shifts the search endtime back by a specified duration (e.g., "1m") to exclude very recent
traces that may still be receiving spans
Hour (-1m)")
traceWithOrphanshelper in demo trace generators for testingHow was this change tested?
transform-trace-data.test.js(5 new tests)applyAdjustTimefunction inSearchForm.test.js(7 new tests)
Search Results - Incomplete Trace Warning Tag
Trace Detail Page - Incomplete Indicator
Search Form - Lookback with Time Adjustment Toggle
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test