Skip to content

Conversation

@yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 26, 2025

An even cleaner approach where we don't define custom colors in vars.css twice, but instead rely on AntD theme support which already defines over 300 --ant-xxx-xxx variables (captured in docs/adr/0001/antd-vars.css added in this PR).

This actually makes the dark theme a lot more usable because by default we're applying colors that AntD already transformed for a dark theme. Of course there are some glitches, e.g. we need to decide what the navbar should look like the dark mode.

image

For comparison, the website now supports dark theme too an its navbar doesn't change between themes

image

It would actually be great if we aligned the actual Jaeger UI with the website look a feel at least on that level.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner December 26, 2025 05:15
@yurishkuro yurishkuro added the changelog:experimental Experimental feature, may not be stable label Dec 26, 2025
@yurishkuro yurishkuro requested review from joe-elliott and removed request for a team December 26, 2025 05:15
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (9c75545) to head (11ae460).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3245   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         261      261           
  Lines        8209     8209           
  Branches     2178     2178           
=======================================
  Hits         8031     8031           
  Misses        175      175           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:experimental Experimental feature, may not be stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants