Define theme vars in terms of AntD vars #3245
Open
+397
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An even cleaner approach where we don't define custom colors in
vars.csstwice, but instead rely on AntD theme support which already defines over 300--ant-xxx-xxxvariables (captured indocs/adr/0001/antd-vars.cssadded in this PR).This actually makes the dark theme a lot more usable because by default we're applying colors that AntD already transformed for a dark theme. Of course there are some glitches, e.g. we need to decide what the navbar should look like the dark mode.
For comparison, the website now supports dark theme too an its navbar doesn't change between themes
It would actually be great if we aligned the actual Jaeger UI with the website look a feel at least on that level.