Skip to content

fix: bug - On initial load of Monitor page the charts are half-width #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gulshank0 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: bug - On initial load of Monitor page the charts are half-width #3555

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1af6f47
fix: bug - On initial load of Monitor page the charts are half-width
gulshank0 Mar 3, 2026
3b15f94
removed as it alredy covered test
gulshank0 Mar 3, 2026
70391fe
using useLayoutEffect instead of the useEffect to prevent flicker and…
gulshank0 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/jaeger-ui/src/components/Monitor/ServicesView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) 2021 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

import React, { useEffect, useState, useRef, useCallback } from 'react';
import React, { useEffect, useState, useRef, useCallback, useLayoutEffect } from 'react';
import { Row, Col, Input, Alert, Select } from 'antd';
import { ActionFunctionAny, Action } from 'redux-actions';
import _debounce from 'lodash/debounce';
Expand Down Expand Up @@ -224,6 +224,14 @@ export function MonitorATMServicesViewImpl(props: TProps) {
};
}, [updateDimensions, calcGraphXDomain]);

// Recalculate graph width once services finish loading, since the graph
// container ref is not mounted while the loading spinner is shown (#3539).
useLayoutEffect(() => {
if (!servicesLoading) {
updateDimensions();
}
}, [servicesLoading, updateDimensions]);
Comment thread
gulshank0 marked this conversation as resolved.

// componentDidUpdate equivalent
useEffect(() => {
if (services.length !== 0) {
Expand Down
Loading