Move pkg/httpmetrics to internal/httpmetrics #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details. - Moved all files from /pkg/httpmetrics to /internal/httpmetrics - Updated all import paths throughout the codebase - No functional changes Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6905 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 342 342
Lines 20272 20272
=======================================
Hits 19510 19510
Misses 576 576
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
added
the
changelog:refactoring
yurishkuro
changed the title
|
Only used in cmd/collector/app/server/http.go. Please move to cmd/collector/app/server/httpmetrics |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
@yurishkuro done |
yurishkuro
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details.
Moved all files from
/pkg/httpmetricsto/internal/httpmetricsUpdated all import paths throughout the codebase
No functional changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test