-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pkg/netutils to internal/netutils #6909
base: main
Are you sure you want to change the base?
Conversation
This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details. - Moved all files from /pkg/netutils to /internal/netutils - Updated all import paths throughout the codebase - No functional changes Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6909 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 339 339
Lines 19597 19597
=======================================
Hits 18840 18840
Misses 572 572
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only functionality in this package is port-related. We have a root package ports/ with some util methods, please move the functions there (assuming they are all even needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase required
Signed-off-by: hippie-danish <[email protected]>
ok , i will move these functions |
Which problem is this PR solving?
Description of the changes
pkg/netutils
tointernal/netutils
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test