Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/netutils to internal/netutils #6909

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danish9039
Copy link
Contributor

@danish9039 danish9039 commented Mar 22, 2025

Which problem is this PR solving?

Description of the changes

  • Migrate pkg/netutils to internal/netutils

How was this change tested?

Checklist

This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details.

- Moved all files from /pkg/netutils to /internal/netutils
- Updated all import paths throughout the codebase
- No functional changes

Signed-off-by: danish9039 <[email protected]>
.
Signed-off-by: danish9039 <[email protected]>
@danish9039 danish9039 requested a review from a team as a code owner March 22, 2025 14:44
@danish9039 danish9039 requested a review from jkowall March 22, 2025 14:44
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (dadc86d) to head (234edb7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6909   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files         339      339           
  Lines       19597    19597           
=======================================
  Hits        18840    18840           
  Misses        572      572           
  Partials      185      185           
Flag Coverage Δ
badger_v1 10.21% <ø> (ø)
badger_v2 2.12% <ø> (ø)
cassandra-4.x-v1-manual 15.36% <ø> (ø)
cassandra-4.x-v2-auto 2.11% <ø> (ø)
cassandra-4.x-v2-manual 2.11% <ø> (ø)
cassandra-5.x-v1-manual 15.36% <ø> (ø)
cassandra-5.x-v2-auto 2.11% <ø> (ø)
cassandra-5.x-v2-manual 2.11% <ø> (ø)
elasticsearch-6.x-v1 20.12% <ø> (ø)
elasticsearch-7.x-v1 20.21% <ø> (ø)
elasticsearch-8.x-v1 20.38% <ø> (ø)
elasticsearch-8.x-v2 2.12% <ø> (ø)
grpc_v1 11.28% <ø> (ø)
grpc_v2 8.25% <ø> (ø)
kafka-3.x-v1 10.51% <ø> (ø)
kafka-3.x-v2 2.12% <ø> (ø)
memory_v2 2.12% <ø> (ø)
opensearch-1.x-v1 20.26% <ø> (ø)
opensearch-2.x-v1 ?
opensearch-2.x-v2 2.12% <ø> (ø)
tailsampling-processor 0.57% <ø> (ø)
unittests 94.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Mar 22, 2025
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only functionality in this package is port-related. We have a root package ports/ with some util methods, please move the functions there (assuming they are all even needed)

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase required

@danish9039
Copy link
Contributor Author

The only functionality in this package is port-related. We have a root package ports/ with some util methods, please move the functions there (assuming they are all even needed)

ok , i will move these functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants