Сache .m2 dependencies #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, every docker build downloaded Maven dependencies on every build. This enables reuse .m2 folder across builds which significantly improves the build times. Signed-off-by: Vladimir Sitnikov <[email protected]>
yurishkuro
reviewed
Feb 5, 2025
| @@ -26,7 +26,7 @@ COPY .mvn $APP_HOME/.mvn | |||
| COPY mvnw $APP_HOME | |||
|
|
|||
| WORKDIR $APP_HOME | |||
| RUN ./mvnw package -Dlicense.skip=true -DskipTests && rm -rf ~/.m2 | |||
| RUN --mount=type=cache,target=/root/.m2 ./mvnw package -Dlicense.skip=true -DskipTests | |||
There was a problem hiding this comment.
how does Maven know to look at root/.m2?
There was a problem hiding this comment.
Check out https://maven.apache.org/settings.html
localRepository: This value is the path of this build system's local repository. The default value is${user.home}/.m2/repository
The username is root, thus /root/.m2
yurishkuro
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every docker build downloaded Maven dependencies on every build. This enables reuse .m2 folder across builds which significantly improves the build times.
Which problem is this PR solving?
Running
docker build .takes time, and most of the time is spent on downloading Maven dependenciesDescription of the changes
Mount
/root/.m2as a cache folderHow was this change tested?
Modify
.javafile, rundocker build ..After the fix, the output does not contain "downloading ..." messages.
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test