-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Spark Cassandra Connector to 3.4.1 #142
Conversation
Can we add that job to the CI before making changes to Cassandra related code? |
@yurishkuro , could you please clarify what exactly do you mean? The current CI fails, see: https://github.com/jaegertracing/spark-dependencies/actions/runs/13158395388/job/36723797004?pr=142#step:5:29234
I believe the root cause is the same as in renovate-bot/jaegertracing-_-jaeger@b34cbf3 since I get the same |
Here's the log for the main branch of
|
it looks like we may need to upgrade the test to use Cassandra v4 (v3 is EOL anyway) |
Frankly, at this point the culprit seems to be that |
Were you able to see these errors in the GitHub runner output, or in a local run only? It seems some parameter to the schema is now required. |
Sure I can do it in GitHub CI if you like.
No I bet "cassandra version autodetect" does not properly work, so it defaults to "the latest .cql.tmpl file in the image" which happends to be |
Note the output:
I believe there's an unexpected newline before |
I couldn't find similar errors in the CI run, it would be good to see them there. |
version 3 is correct. v4 template is also correct. However |
7980971
to
02f6bb1
Compare
Previously, Spark Cassandra Connector and Spark Core was using metrics-core 3.x and 4.x respectively. Bumping Cassandra Connector integrates a newer Cassandra Java Driver, so it does not interfere with spark's metrics-core version. Fixes jaegertracing#138 Signed-off-by: Vladimir Sitnikov <[email protected]>
Unfortunately, this does not fix Docker image as it still fails as follows:
|
I believe the root cause is that
If I apply @yurishkuro , what do you think of deactivating Just for the reference, We can try adding <filter>
<artifact>com.datastax.oss:*</artifact>
<includes>
<include>**</include>
</includes>
</filter> The resulting jar becomes 191M. However, I am not sure if |
Agreed. But I also wonder why didn't our CI catch that, probably because we don't do a proper e2e test running the job's code from a container. |
Which problem is this PR solving?
Description of the changes
Previously, Spark Cassandra Connector and Spark Core was using metrics-core 3.x and 4.x respectively. Bumping Cassandra Connector integrates a newer Cassandra Java Driver, so it does not interfere with spark's metrics-core version.
How was this change tested?
CassandraDependenciesJobTest
does not seem to work due to renovate-bot/jaegertracing-_-jaeger@b34cbf3Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test