Keep classes from Cassandra Java Driver #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves Caused by: java.lang.IllegalArgumentException: Can't find class DefaultMetricsFactory (specified by advanced.metrics.factory.class) at com.datastax.oss.driver.internal.core.util.Reflection.resolveClass(Reflection.java:302) at com.datastax.oss.driver.internal.core.util.Reflection.buildFromConfig(Reflection.java:235) at com.datastax.oss.driver.internal.core.util.Reflection.buildFromConfig(Reflection.java:110) at com.datastax.oss.driver.internal.core.context.DefaultDriverContext.buildMetricsFactory(DefaultDriverContext.java:548) Signed-off-by: Vladimir Sitnikov <[email protected]>
|
@yurishkuro , do you think this is mergeable? Frankly, I'm not very fluent with Maven to make it execute tests over the shaded artifacts. |
yurishkuro
reviewed
Feb 11, 2025
I could make it if the build was Gradle-based. For Maven, the answer seems to use "maven invoker" plugin (I've never used it though): https://stackoverflow.com/a/74302074 |
yurishkuro
approved these changes
Feb 11, 2025
|
ok, then can you test manually and post evidence? |
|
Closing in favour of #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Include all the classes from Cassandra Java Driver as it includes shaded dependencies.
How was this change tested?
Note that both
jaeger-spark-dependencies-cassandraandjaeger-spark-dependencies-elasticsearchtest unshaded artifacts, so they do not detect issues caused by shading.Previously, local execution of
STORAGE=cassandra CASSANDRA_USERNAME=cassandra CASSANDRA_PASSWORD=cassandra java -jar jaeger-spark-dependencies-0.0.1-SNAPSHOT.jarreproducedCan't find class DefaultMetricsFactoryAfter the fix, the error is gone.
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test