feat: Fix global reference when importing as module#524
Open
jblumie wants to merge 1 commit intojagenjo:masterfrom
Open
feat: Fix global reference when importing as module#524jblumie wants to merge 1 commit intojagenjo:masterfrom
jblumie wants to merge 1 commit intojagenjo:masterfrom
Conversation
When importing as a module `this` isn't defined, and should be `globalThis` instead. I think this is also the error behind jagenjo#461 but I don't use vite to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing as a module
thisisn't defined, and should beglobalThisinstead. I think this is also the error behind #461 but I don't use vite to test.