feat(signUp_verification_status): Sign up email/phone verification status fix #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion status UserAttributes
…us in the IdToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has an unverified email address or phone number allocated at signUp, real Cognito returns user attributes for email_verified = false and phone_number_verifed = false when doing a getUserByUsername. When they don't have an email - the email_verified is not set either. Similar for no phone number. Cognito-local only returns the verification status once it's true.
I've partially implemented that, since I needed it. It only works for users signed up with the email address as the primary identifier (I don't think cognito-local supports phone number only signups anyway?).
It's a bit hacky - I struggled to understand how the signup without pre-signup lambda was supposed to work - so it might need a bit of tidying up. But i works for me now.