fix valid_url?/1 accepting stray digits between TLD and port#19
Merged
Conversation
The leading ([0-9]{1,5})? group in @url_regexp accepted bare digits
glued onto the TLD, so URLs like `https://example.com8080` and
`https://example.com12345/path` matched. The group had no purpose —
real ports must be preceded by `:`, already covered by (:(\d{1,5}))?.
Drop it.
There was a problem hiding this comment.
Pull request overview
Fixes Funkspector.Utils.valid_url?/1 so it no longer accepts URLs with stray digits appended directly after the TLD (e.g., https://example.com8080) by tightening the URL regexp and adding regression tests.
Changes:
- Remove an unused digit-matching group in
@url_regexpthat allowed digits between the TLD and the optional port/path. - Add tests asserting such “TLD+digits” URLs are rejected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/utils_test.exs | Adds regression tests for invalid URLs with stray digits after the TLD. |
| lib/funkspector/utils.ex | Updates @url_regexp to require ports to be preceded by : and disallow glued-on digits after the TLD. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leading ([0-9]{1,5})? group in @url_regexp accepted bare digits glued onto the TLD, so URLs like
https://example.com8080andhttps://example.com12345/pathmatched. The group had no purpose — real ports must be preceded by:, already covered by (:(\d{1,5}))?.Fixes #18