Skip to content

Make a couple of changes to CMakeLists.txt to facilitate MSVC builds #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jurplel wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make a couple of changes to CMakeLists.txt to facilitate MSVC builds #21

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
677ff7f
Replace libheif pkgconfig with vcpkg-compatible find_package
jurplel Oct 2, 2020
faa88fc
Only use compiler flags on clang or gcc
jurplel Oct 2, 2020
71f30be
Revert "Replace libheif pkgconfig with vcpkg-compatible find_package"
jurplel Oct 2, 2020
24bf681
Add target_include_directories and link_directories from pkgconfig
jurplel Oct 2, 2020
6a855ac
Fix duplicated line
jurplel Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ endif ()

# compiler flags
# TODO: separate GCC and Clang warnings; add more
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")
set(
CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} \
-Wall \
Expand All @@ -26,6 +27,7 @@ set(
-Wformat-security \
-Wnon-virtual-dtor \
")
endif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")

set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Og")

Expand Down Expand Up @@ -55,6 +57,8 @@ set(CMAKE_INCLUDE_CURRENT_DIR ON)

set(sources main.cpp qheifhandler.cpp)

link_directories(${libheif_LIBRARY_DIRS})

add_library(qheif MODULE ${sources})

target_link_libraries(
Expand All @@ -64,6 +68,8 @@ target_link_libraries(
${libheif_LIBRARIES}
)

target_include_directories(qheif PRIVATE ${libheif_INCLUDE_DIRS})

#
# installation
#
Expand Down