Skip to content

Ignore: jruby 10.0.0.0 #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Apr 24, 2025

Fixes #696

Asciidoctor does not yet support jruby 10. See error:

Error:  Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:3.2.0:process-asciidoc (asciidoc-to-pdf) on project jakarta.data-tck-dist: Execution asciidoc-to-pdf of goal org.asciidoctor:asciidoctor-maven-plugin:3.2.0:process-asciidoc failed: (ArgumentError) wrong number of arguments (given 3, expected 1..2): (LoadError) no such file to load -- asciidoctor-pdf -> [Help 1]

@KyleAure KyleAure added the dependencies Pull requests that update a dependency file label Apr 24, 2025
@KyleAure KyleAure self-assigned this Apr 24, 2025
@KyleAure KyleAure changed the title deps: ignore jruby 10 Ignore: jruby 10.0.0.0 Apr 24, 2025
ignore:
#TODO wait until we are building with Java 21 and Asciidoctor is updated to support jruby 10
- dependency-name: "org.jruby:jruby"
- versions: [ ">10.0.0.0" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#versions-ignore shouldn't it be something like

ignore:
  - dependency-name: "..."
    versions: [10,)

? (Note: in my comment the versions is not introduced with dash as new element.)

Isn't the current version going to ignore BOTH - dependencies if named - as specified, OR in versions as specified? (+I'm unfamiliar with '>10.0.0.0' syntax for maven versions.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good catch. I must have been looking at the syntax documentation for the wrong type of package manager. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants