Literal for Schedule annotation #814
Open
+247
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
reviewed
Jan 16, 2026
| final long skipIfLateBy, | ||
| final String zone) { | ||
|
|
||
| if (cron == null) { |
Contributor
There was a problem hiding this comment.
Could potentially use Objects.requireNonNull from the JDK
Member
Author
There was a problem hiding this comment.
Good idea. That makes it much more concise. Updated in ca7eb14
arjantijms
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literal for the
@Scheduleannotation, similar to what we have for@Lockand the proposed@Poolable.I also noticed Javadoc return for Schedule's
zone()is missing and added it.