Fix #211 - add context marker for single, stand-alone identifiers #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fiers The presence of this marker will allow resolvers, particularly jakarta.servlet.jsp.el.ImportELResolver to optimise lookups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of this marker will allow
ELResolverinstances, particularlyjakarta.servlet.jsp.el.ImportELResolver, to optimise lookups.This provides the machinery on the EL side of things to fix jakartaee/pages#245
It includes a couple of new TCK tests that check the marker is set (or not set) correctly.
I'll leave this open for a week or so to give folks a chance to comment. There haven't been any comments on the proposed approach and that has been posted for over a year but I'm allowing time just in case a concrete implementation means someone spots something they hadn't though of previously.