Remove DEFAULT_JAXWSPROVIDER fallback class name#132
Open
jGauravGupta wants to merge 2 commits into
Open
Conversation
Signed-off-by: Gaurav Gupta <gaurav.gupta@payara.fish>
lukasj
requested changes
Jun 3, 2020
lukasj
left a comment
lukasj
left a comment
Contributor
There was a problem hiding this comment.
This constant is to be removed instead. Also proper error message should appear if no provider is found.
Contributor
|
btw: did you check #90 before creating this? |
Signed-off-by: Gaurav Gupta <gaurav.gupta@payara.fish>
jGauravGupta
changed the title
Member
Author
|
Hi @lukasj, I missed that ticket. Thanks for the suggestions, I have updated PR. |
|
What about adding a static overload to
As a side note, I believe the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gupta gaurav.gupta@payara.fish
Seems
com.sun.xml.internal.ws.spi.ProviderImplrefactored tocom.sun.xml.ws.spi.ProviderImplearlier but package is not renamed inProviderclass.See the package of ProviderImpl.java.