Add nullability annotation based on JavaDoc#637
Open
schnapster wants to merge 1 commit intojakartaee:mainfrom
Open
Add nullability annotation based on JavaDoc#637schnapster wants to merge 1 commit intojakartaee:mainfrom
schnapster wants to merge 1 commit intojakartaee:mainfrom
Conversation
Signed-off-by Dennis Neufeld dennis.neufeld@innogames.com
e9d1951 to
2ed3a24
Compare
Author
|
Ahoi @markt-asf would you be willing to help me make this changeset land in the project? How can I make this move forward? |
Contributor
|
Adding a dependency to the Servlet API is a big deal that needs a wider discussion and broad consensus. Personally, I'm not (yet) convinced of the need for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This morning I was greeted by a nice error in our production service:
Oof.
The docs of
HttpServletRequest#getCookies()clearly state it may return null, however its 2024 andI have therefore given the JavaDocs of Jakarta Servlet a cursory look and implemented nullability annotations where I deemed them sufficiently indicated.
This should help all devs using modern IDEs and modern compilers (e.g. Kotlin): they will see warnings when accessing nullable values without explicit null checks.
I've probably missed some places, but I hope this PR by itself already provides enough value to the project to be merged.
Please let me know with any feedback or anything missing.