Skip to content

Jakarta Standard Tag Library 3.1.0 plan review #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Jakarta Standard Tag Library 3.1.0 plan review #824

wants to merge 1 commit into from

Conversation

pnicolucci
Copy link
Contributor

@pnicolucci pnicolucci commented Apr 14, 2025 •
edited
Loading

Plan Review PR template

When creating a specification project plan review, create PRs with the content defined as follows.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version.
  • An index page wombat/x.y/_index.md following template
  • Title should be on the form "Jakarta Wombat X.Y (under development)"
  • Includes a plan for the release. Usually, a couple of statements is enough. Otherwise, a link to a document describing the release.
  • N/A Includes a detailed description of any backward incompatibility (Mark with N/A and check if none)
  • N/A Declares optional features if there are any (Mark with N/A and check if none)
  • Includes minimum Java SE version
  • Describe any updates or required changes including splitting out the TCK (Mark with N/A and check if not planned)
  • Link to updated release record

@netlify Netlify
Copy link

netlify bot commented Apr 14, 2025

✅ Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit e325b64
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/67fd1c6efd9ee20008d43e90
😎 Deploy Preview https://deploy-preview-824--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pnicolucci pnicolucci mentioned this pull request Apr 9, 2025
Open
@netlify Netlify
Copy link

netlify bot commented Apr 14, 2025

✅ Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit fdecd4d
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/67fd1c9fc5fc79000884b621
😎 Deploy Preview https://deploy-preview-824--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 14, 2025

✅ Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit a4b8f30
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/67fd1d76e677170008b20ddd
😎 Deploy Preview https://deploy-preview-824--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pnicolucci pnicolucci marked this pull request as ready for review April 14, 2025 14:43
@ivargrimstad ivargrimstad added the plan review Use this label on PRs that are filed for plan reviews label Apr 14, 2025
Emily-Jiang
Emily-Jiang reviewed Apr 22, 2025
View reviewed changes
tags/3.1/_index.md
# Details
* [Jakarta Standard Tag Library 3.1 Release Record](https://projects.eclipse.org/projects/ee4j.jstl/releases/3.1.0)
<!-- The following can be uncommented and version information updated as they become available.
* [Jakarta Standard Tag Library 3.0 Specification Document](./jakarta-tags-spec-3.0.pdf) (PDF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 3.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment applies to all of the following sections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emily-Jiang this is currently commented out and won't be displayed anyplace, I followed a similar structure to what was done for Servlet 6.2: https://github.com/jakartaee/specifications/pull/807/files I can make these changes but they won't point to any existing artifacts. Do you still want me to update?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnicolucci okay. I think this PRs are not consistent as some PRs have updated the versions. Anyway, it is not a big deal as you said they are commented out.

pnicolucci
pnicolucci commented Apr 22, 2025
View reviewed changes
tags/3.1/_index.md

# Details
* [Jakarta Standard Tag Library 3.1 Release Record](https://projects.eclipse.org/projects/ee4j.jstl/releases/3.1.0)
<!-- The following can be uncommented and version information updated as they become available.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emily-Jiang I have a comment saying to uncomment update the version information as it become available. Is this ok given the comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emily-Jiang Emily-Jiang Emily-Jiang left review comments

@volosied volosied volosied approved these changes

Assignees
No one assigned
Labels
plan review Use this label on PRs that are filed for plan reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pnicolucci @volosied @Emily-Jiang @ivargrimstad