Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 2072355 | Previous: 96c507a | Ratio |
|---|---|---|---|
cpython |
0.0009388929399999999 seconds (± 0) |
0.0009261307400000001 seconds (± 0) |
1.01 |
airflow |
0.0009394677400000001 seconds (± 0) |
0.0009039711400000002 seconds (± 0) |
1.04 |
prefect |
0.0009405571399999999 seconds (± 0) |
0.0009188860400000002 seconds (± 0) |
1.02 |
ruff |
0.0009300180400000002 seconds (± 0) |
0.0009381282400000001 seconds (± 0) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 98.66% 98.69% +0.02%
==========================================
Files 21 22 +1
Lines 3305 3300 -5
==========================================
- Hits 3261 3257 -4
+ Misses 44 43 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Refactor: merge ensure_git_repo into git_repo_root, extract run_git helper and git_messages const fn to eliminate duplicated unreachable NotFound error handling across 3 functions - Add unit tests for git_filter_from_args, apply_git_filter, run_git, git_repo_root, list_git_paths (staged, diff, invalid ref, dedup) - Add unit tests for normalize_path_lexical edge cases (CurDir, double ParentDir, empty, root parent) - Add unit tests for normalize_scope_path and candidate_in_scope - Remaining 14 uncovered lines: 11 Windows-only Component::Prefix paths (covered on Windows CI), 3 deep IO error edge cases
On Windows, git rev-parse --show-toplevel returns forward-slash paths (e.g. C:/Users/runneradmin/...) while std::env::current_dir() may return short 8.3 names (e.g. C:\Users\RUNNER~1\...). This mismatch causes starts_with comparisons to fail, resulting in 0 files checked. Use dunce::canonicalize on both cwd and repo root to resolve paths to their canonical form before comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds git-aware filters to
loq checkto remove common git piping in CI/pre-commit workflows.--stagedchecks staged files;--diff <ref>checks files changed since a ref; path args intersect with the git file list.This makes git workflows simpler while keeping scope controls intact.
Example:
CLOSES #20