This repository was archived by the owner on Oct 26, 2025. It is now read-only.
Run ng-annotate before babelify#214
Open
chrisparton1991 wants to merge 1 commit intojakemmarsh:masterfrom
chrisparton1991:fix-ngannotate
Open
Run ng-annotate before babelify#214chrisparton1991 wants to merge 1 commit intojakemmarsh:masterfrom chrisparton1991:fix-ngannotate
chrisparton1991 wants to merge 1 commit intojakemmarsh:masterfrom
chrisparton1991:fix-ngannotate
Conversation
Author
|
Looks like this screws up sourcemap generation, unfortunately, I'll have to investigate. Any ideas why this would happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a controller that looks something like this (simplified for example's sake):
When built, babel prepends an underscore to the
momentvariable to ensure there are no conflicts with global scope. The result looks something like:Next, ng-annotate comes along and adds the dependency array:
Because
_momentisn't a valid dependency, an exception is thrown. Both libraries are doing the right thing, but together they create a painful issue.Long story short, I've found that running ng-annotate before babel fixes the issue, as babel hasn't had its way with the parameter names yet. I can't see any issues with running ng-annotate first, but I could be mistaken.
P.S. love your work this this seed project, thanks!