Skip to content

Do not reset newly created scroller; reset height on destroy #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not reset newly created scroller; reset height on destroy #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion coffeescripts/jquery.nanoscroller.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,7 @@
do @pane.remove if not @iOSNativeScrolling and @pane.length
@$content.height '' if BROWSER_IS_IE7
@$content.removeAttr 'tabindex'
@$el.height("")
if @$el.hasClass('has-scrollbar')
@$el.removeClass('has-scrollbar')
@$content.css right: ''
Expand All @@ -824,9 +825,11 @@

$.fn.nanoScroller = (settings) ->
@each ->
newScroller = false
if not scrollbar = @nanoscroller
options = $.extend {}, defaults, settings
@nanoscroller = scrollbar = new NanoScroll this, options
newScroller = true

# scrollbar settings
if settings and typeof settings is "object"
Expand All @@ -841,7 +844,10 @@
return do scrollbar.destroy if settings.destroy
return do scrollbar.flash if settings.flash

do scrollbar.reset
if !newScroller
return do scrollbar.reset

return this

$.fn.nanoScroller.Constructor = NanoScroll
return