Proof of concept - use vitest instead of mocha/should#2
Open
jameslounds wants to merge 12 commits intofeat/typescript-migrationfrom
Open
Proof of concept - use vitest instead of mocha/should#2jameslounds wants to merge 12 commits intofeat/typescript-migrationfrom
jameslounds wants to merge 12 commits intofeat/typescript-migrationfrom
Conversation
…, ddata, settings, language, times, units, levels to typescript
jameslounds
commented
Dec 2, 2024
…th typescript too)
…pills rendered correctly
…ach time Also makes `removeScriptTags` a function and uses it in `pluginbase.test.js`
jameslounds
force-pushed
the
proof-of-concept/vitest
branch
from
a6d446c to
ab577cb
Compare
fixes weirdness around `stream` and `crypto` with slightly weird `define: {"process.browser": true}` in `vite.config.ts`
jameslounds
force-pushed
the
proof-of-concept/vitest
branch
from
ab577cb to
849af2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mostly a proof of concept to demonstrate what tests would look like with vitest, and what a few files might look like after bieng migrated to typescript