Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi James,
I have been watching your work on modernising NightScout since I was diagnosed in November, and finally felt like I could perhaps contribute something- it's not much, but it's honest work.
Do you have plans to make use of a framework such as Svelte or React further down the line? The string concatenation approach is very brittle, and we could make huge improvements in accessibility and maintainability with a modern toolbox at our disposal.
Let me know if I can do anything to help, or improve this PR. Happy to take on more "grunt work" if it's of any help!
Cheers