Skip to content

Test against Ruby 4.0 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tagliala wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test against Ruby 4.0 #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/integration_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Checkout test app
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: jamesmartin/inline_svg_test_app
ref: ${{ matrix.test-branch }}
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
cd $GITHUB_WORKSPACE/test_app
bundle install --jobs 4 --retry 3
- name: Set up Node.js 20.x
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: 20
if: matrix.test-branch == 'rails7-shakapacker'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.4']
ruby-version: ['4.0']

continue-on-error: ${{ matrix.channel != 'stable' }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.1', '3.2', '3.3', '3.4']
ruby-version: ['3.1', '3.2', '3.3', '3.4', '4.0']
channel: ['stable']

include:
Expand All @@ -25,7 +25,7 @@ jobs:
continue-on-error: ${{ matrix.channel != 'stable' }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand Down
33 changes: 18 additions & 15 deletions .rubocop_todo.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ gem "pry"
gem "rake"
gem "rspec"

gem "rubocop", "1.75.3", require: false
gem "rubocop", "1.85.0", require: false
gem "rubocop-packaging", "0.6.0", require: false
gem "rubocop-performance", "1.25.0", require: false
gem "rubocop-performance", "1.26.1", require: false
gem "rubocop-rake", "0.7.1", require: false
gem "rubocop-rspec", "3.6.0", require: false
gem "rubocop-rspec", "3.9.0", require: false

gem "simplecov", require: false
2 changes: 1 addition & 1 deletion lib/inline_svg.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def raise_on_file_not_found?
private

def incompatible_transformation?(klass)
!klass.is_a?(Class) || !klass.respond_to?(:create_with_value) || !klass.instance_methods.include?(:transform)
!klass.is_a?(Class) || !klass.respond_to?(:create_with_value) || !klass.method_defined?(:transform)
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/helpers/inline_svg_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def transform(doc)
end

RSpec.describe InlineSvg::ActionView::Helpers do
let(:helper) { (Class.new { include InlineSvg::ActionView::Helpers }).new }
let(:helper) { Class.new { include InlineSvg::ActionView::Helpers }.new }

shared_examples "inline_svg helper" do |helper_method:|
after do
Expand Down