Update for postcard-schema-ng traits and types.#120
Draft
rslawson wants to merge 1 commit into
Draft
Conversation
rslawson
commented
Jun 18, 2025
| let (arr1, used): ([Option<_>; MAX1], usize) = type_chewer_dmt(Example1::SCHEMA); | ||
| assert!(!is_prim(Example1::SCHEMA)); | ||
| let child_ct = unique_types_dmt_upper(Example1::SCHEMA); | ||
| assert_eq!(child_ct, 2); |
Author
There was a problem hiding this comment.
I'm very unsure whether this was the right change to make. The diff compared to base is that it was originally let child_ct = unique_types_dmt_upper(Example1::SCHEMA.ty);, but I'm not sure how to do an equivalent to the .ty anymore since I don't have a unique_types_data_upper, just unique_types_dmt_upper and unique_types_var_upper.
jamesmunns
added
the
Q2 '25 Triage
rslawson
changed the title
postcard-schema traits and types.postcard-schema-ng traits and types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present I know there's some things that still need doing here: namely that the
patchsection inCargo.tomlneeds to be removed, and I need to figure out why I had to change a constant in one of the tests. Other than that, though, I think it's probably good to go except maybe some doc comments here or there that I might've forgotten about?