Implement Schema and MaxSize for nalgebra::{Quaternion,Unit}#242
Merged
jamesmunns merged 1 commit intojamesmunns:james/bifurcate-schemafrom Jun 19, 2025
Merged
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
Owner
|
Btw, I'm doing the "split things into |
Merged
MaxSize impls are gated under a new nalgebra-v0_33 feature flag for postcard analogous to the existing feature for postcard-schema.
Owner
|
Do you want to change the merge target to james/bifurcate-schema and we can just roll it up there? |
Collaborator
Author
Already did :) |
Owner
|
Hell yeah :) |
jamesmunns
approved these changes
Jun 19, 2025
jamesmunns
merged commit 77524da
into
jamesmunns:james/bifurcate-schema
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaxSize impls are gated under a new nalgebra-v0_33 feature flag for postcard analogous to the existing feature for postcard-schema.