Skip to content

copilot: support Copilot authentication and service#10

Open
mathstuf wants to merge 1 commit into
jamespember:mainfrom
mathstuf:copilot-support
Open

copilot: support Copilot authentication and service#10
mathstuf wants to merge 1 commit into
jamespember:mainfrom
mathstuf:copilot-support

Conversation

@mathstuf

Copy link
Copy Markdown
Contributor

Co-authored-by: GitHub Copilot(claude-opus-4.6)
Fixes: #2


Based on #9 and #5.

@mathstuf mathstuf force-pushed the copilot-support branch 2 times, most recently from 162c63c to 4279ff1 Compare March 18, 2026 04:55
@mathstuf mathstuf force-pushed the copilot-support branch from 4279ff1 to 887741a Compare May 4, 2026 13:17
@mathstuf mathstuf marked this pull request as ready for review May 4, 2026 13:18
@mathstuf mathstuf requested a review from jamespember as a code owner May 4, 2026 13:18

@fredheir fredheir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking correctness issue: CopilotSummarizer defines CopilotTokenManager, but the client path sends the long-lived GitHub OAuth token directly to https://api.githubcopilot.com. That bypasses the /copilot_internal/v2/token exchange and will fail for the intended Copilot API flow.

I prepared and tested a local patch that changes _get_client() to call CopilotTokenManager.get_token(), invalidates that session token on retry, removes the setup_cloud.sh TODO cost text, and adds focused tests proving the OpenAI-compatible client receives the Copilot session token rather than the GitHub OAuth token. Proof run locally: uv run --extra dev --extra copilot -m pytest -q tests/test_summarizers.py -> 10 passed; uv run --extra dev --extra copilot ruff check meeting_notes/copilot_auth.py meeting_notes/ai_summarizer.py tests/conftest.py tests/test_summarizers.py -> passed.

I cannot push to mathstuf/meeting-notes-tui from this token despite maintainerCanModify, so the branch cannot be updated in place from here.

@fredheir

Copy link
Copy Markdown

Reference branch with the tested fix, since I cannot push to the contributor fork directly: https://github.com/Markolo-Research/meeting-notes-streaming/tree/codex/pr10-copilot-session-token-fix

Incremental commit range in my worktree: 887741a..fe6ce29.

@mathstuf

Copy link
Copy Markdown
Contributor Author

Your fork is private and I cannot access it.

@mathstuf

Copy link
Copy Markdown
Contributor Author

I have a diff assisted by DeepSeek applied now. @fredheir is this similar to what you have?

@fredheir

Copy link
Copy Markdown

@mathstuf my apologies, my agent went rogue.
I've set my fork to public, perhaps this can still be useful for you.

Fixes-by: Rolf Fredheim <rolf@markolo.eu> (agent-assisted)
Co-authored-by: GitHub Copilot (claude-opus-4.6)
Fixes: jamespember#2
@mathstuf

Copy link
Copy Markdown
Contributor Author

Thanks; I've integrated the changes in (except the spurious whitespace diffs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: Support Copilot as a cloud provider

2 participants