Added quick add endpoint option for task creation (for Todoist natural language parsing)#424
Open
NimbleShot wants to merge 1 commit intojamiebrynes7:masterfrom
Open
Added quick add endpoint option for task creation (for Todoist natural language parsing)#424NimbleShot wants to merge 1 commit intojamiebrynes7:masterfrom
NimbleShot wants to merge 1 commit intojamiebrynes7:masterfrom
Conversation
Toggleable in the "Add task" pane
Owner
There was a problem hiding this comment.
I think a better pattern for deciding whether to use the quick add or not is:
- store a default value in the settings
- allow the user to change the value within the task modal without changing the settings
- pass the value along with the create task payload instead of fetching it from the settings again
Given the new endpoint doesn't support explicit setting of date/project/labels, we should probably disable those inputs when the quick add setting is enabled in the modal
| ...((options?.labels ? { labels: options.labels.join(",") } : {})), | ||
| ...((options?.priority ? { priority: String(options.priority) } : {})), | ||
| }); | ||
| await this.doQuickAdd("https://api.todoist.com/sync/v9/quick/add", body); |
Owner
There was a problem hiding this comment.
The sync API is deprecated and will be removed towards the end of the year, it looks like there is a quick add endpoint on the new API, but it looks slightly different, can we pivot onto that one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggleable in the "Add task" pane