Fix infinite loop#49
Open
seedofjoy wants to merge 2 commits into
Open
Conversation
Fixes infinite loop in case when number or letter appears outside of parentheses. For example: `(add 1 2)5` or `(add 2 3)abs`
Owner
|
Wait, |
Author
|
Sorry, it returns Try this example: That's because |
tailhook
reviewed
Dec 8, 2016
| // we encounter a character that is not a number, pushing each character | ||
| // that is a number to our `value` and incrementing `current` as we go. | ||
| while (NUMBERS.test(char)) { | ||
| while (char && NUMBERS.test(char)) { |
There was a problem hiding this comment.
Maybe while(current < input.length && ... ) ?
|
may be stupid advice, in the while loop of function tokenizer, there is a let variable named char, but char is a keyword in other language,like c or some others. may be chose another name. |
|
it's only a demo, isn't it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes infinite loop in case when number or letter appears outside of parentheses.
/some-regex/.test(undefined)always returns trueFor example:
(add 1 2)5(add 2 3)abs