Fix listeners leak when using with componentDidCatch #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've investigated a bug in my application coming from the use of
unstated
andcomponentDidCatch
.At some point
container.setState
was returning a never-fulfilled promise. React was logging:When an error is thrown during the render phase, the
componentWillUnmount
is never called, and the component doesn't unsubscribe from the container.When calling
setState
, since the component for the listener is unmounted,onUpdate
returns a never-fulfilled promise.Potential solution: I'm experimenting moving the subscribe calls to a safe place
componentDidMount
(which happens during the commit phase, see this comment that explains it).Any way, I'd love to get your feedback on what could be the best approach to fix this 🙌
TLDR: When using
unstated
withcomponentDidCatch
, it leaks listeners, and preventsetState
from being fulfilled.