Fix #180: Add error when occs/bg predictor values are all NA - #181
Open
fdecunta wants to merge 1 commit into
Open
Fix #180: Add error when occs/bg predictor values are all NA #181fdecunta wants to merge 1 commit into
fdecunta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error is explained in the issue: #180
It is an edge case in which all the coordinates from
occsorbgfall outside the extent ofenvs. Extracting values withterra::extractreturn all NAs, but the crash is produced downstream with an unrelated error message.This patch adds a check after extracting the values and raising an error that tries to guide the user into the possible cause.
It passes all tests, and I manually tested that it fixes the problem.