Skip to content

Change frames per second (fps) from usize to f32 #148

Merged
jamjamjon merged 2 commits into
jamjamjon:mainfrom
paulingalls:main
Oct 14, 2025
Merged

Change frames per second (fps) from usize to f32 #148
jamjamjon merged 2 commits into
jamjamjon:mainfrom
paulingalls:main

Conversation

@paulingalls

Copy link
Copy Markdown
Contributor

Some videos have frame rates like 29.97 and so fps needs to be represented as a float.

@jamjamjon

Copy link
Copy Markdown
Owner

@paulingalls Thanks for the contribution — looks great overall!
Before merging, could you please run

cargo fmt --all
cargo clippy --all-features --all-targets -- -D warnings

so the CI checks can pass?

@paulingalls

Copy link
Copy Markdown
Contributor Author

Looks like all the checks now pass. Thanks for having a look!

@jamjamjon jamjamjon merged commit 5cfbb20 into jamjamjon:main Oct 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants