Allow to disable GC within documents using env variable/CLI #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Adds an option to disable GC within documents (distinct from GC of documents in multi-document mode) via:
--skip-gcto either ofy-sweet serveory-sweet serve-docY_SWEET_SKIP_GCenvironment variableI was not sure if I should also add the environment variable to
y-sweet-workerfor feature parity but given that it is deprecated I went for a smaller changeset and only added it in the server.I wonder if the configuration for toggling GC of documents themselves (the
doc_gcoption which is not exposed by clap) would be advisable, but I think it is already possible to configurecheckpoint_freq_secondsinstead which can be set to a very high value that is probably better than turning it off altogether.