fix(s3): treat any 2xx as success in store_request#430
Open
tpjg wants to merge 5 commits into
Open
Conversation
added 5 commits
June 3, 2026 09:49
A successful S3 DELETE returns 204 No Content, not 200. The previous
match only accepted StatusCode::OK, so every successful delete fell
through to the catch-all arm and was misreported as a ConnectionError
("Received 204 No Content from S3-compatible API."). Accept any 2xx.
…unded growth Awareness::remove_state removed the client from `states` but update_meta left a permanent entry in `meta`. On a long-lived server-side Awareness (one per loaded document), this grows by one entry for every client session that ever connected - a slow, unbounded memory leak on documents that never go idle. remove_state now also prunes meta entries that have no corresponding state and were last touched more than 30s ago (the y-protocols outdatedTimeout convention). The grace window preserves the clock check that rejects stale updates from a just-disconnected client. Uses time::OffsetDateTime rather than std::time::Instant because y-sweet-worker compiles this crate to wasm32, where Instant::now panics.
…dirty flag (jamsocket#417), pycrdt bound (jamsocket#414)
Every DocConnection subscribes to the shared Awareness, so an awareness update applied from one connection was broadcast to all connections including the one that sent it. The sender then absorbs the echo via the logical-clock check, but it doubles awareness traffic per update and, combined with clients that rebroadcast remote-origin updates (npm @y-sweet/client <= 0.9.1 does), produces a sustained recv->send ping-pong pattern between idle clients. Tag awareness updates with a per-connection origin id (Awareness::apply_update_from / Protocol::handle_awareness_update_from) and skip the broadcast callback on the originating connection. Changes with no connection origin (e.g. state removal on disconnect) still reach every connection.
handleAwarenessUpdate re-broadcast every awareness update regardless of origin (inherited from y-websocket), so every update received from the server was immediately sent back to it. The server absorbs the duplicate via the logical-clock check, but with two idle clients each received awareness frame still triggered an outgoing frame - a continuous recv->send ping-pong that doubles awareness traffic. Skip broadcasting updates whose origin is the provider itself (i.e. applied from a server message), except entries for our own clientID: y-protocols bumps the local clock and keeps the state when a remote update tries to remove it, and that re-assertion must reach the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful S3 DELETE returns 204 No Content, not 200. The previous match only accepted StatusCode::OK, so every successful delete fell through to the catch-all arm and was misreported as a ConnectionError ("Received 204 No Content from S3-compatible API."). Accept any 2xx.