#50 Auto-resolve Liquid asset ID in sideshift send#87
Merged
Conversation
Collaborator
|
Checks are failing after PR #86 merged — looks like the branch needs to be rebased onto develop to pick up the is_mnemonic_encrypted → requires_user_password rename. Happy to re-review once the tests are green. |
marinate305
approved these changes
Jun 4, 2026
marinate305
left a comment
Collaborator
There was a problem hiding this comment.
Tests are green and conflicts resolved. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Auto-resolve the Liquid asset ID from the deposit coin ticker in
sideshift_send, eliminating the UX friction where non-L-BTC Liquid assets (e.g. USDt) required manually passing a 64-char hex--liquid-asset-id.Closes #50 sideshift send: requires --liquid-asset-id manually for non-L-BTC assets
Main Changes
resolve_liquid_asset_id()inassets.py— single source of truth that maps a (coin, network) pair to a Liquid asset hex ID, short-circuits toNonefor non-Liquid networks and L-BTC, raisesValueErrorwith actionable known-ticker list for unknown tickers, and passes explicit overrides through unchangedtools.sideshift_sendto callresolve_liquid_asset_idbefore contacting the SideShift manager — unknown tickers fail fast before any custodial order is createdcli/sideshift.py(now delegates to the shared helper)sideshift_sendprompt — AI assistants no longer need to look upliquid_asset_idmanually vialw_list_assetsTestResolveLiquidAssetId(10 cases) intest_assets.pyandTestToolsSideShiftSendAutoResolve(5 cases) intest_sideshift.pyChecklist