84 default password encryption v2#94
Closed
andycreed0x wants to merge 4 commits into
Closed
Conversation
…ssword All mnemonics are now encrypted on disk even when the user provides no password. New prefix-tagged storage format (`default:1:`, `user:`, `plain:` legacy read-only, untagged legacy) makes each blob self-describing. Lazy migration converts existing `plain:` wallets to `default:1:` on next read via a single choke point (`Storage.read_and_migrate_mnemonic`). Renames `is_mnemonic_encrypted` → `requires_user_password` across all 9 production + 7 test call sites to correctly distinguish on-disk encryption from user-password requirement. Adds 21 unit tests covering prefix detection, migration round-trip, truth table, signing flows, atomicity, and write-failure tolerance.
Cover the four malformed prefix shapes that retrieve_mnemonic must
reject with a "Malformed default-encrypted mnemonic prefix" error
("default:", "default:novalidversion", "default::blob", "default:abc:blob"),
plus a regression test that the error message truncates arbitrarily
long inputs to avoid leaking ciphertext in logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.