-
Notifications
You must be signed in to change notification settings - Fork 12
Add Support for Firefox #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I would like to migrate the build rig to use the cross-browser extension framework https://crxjs.dev/guide/installation/create-crxjs at some point I leave it to your judgement about whether it's easier to accomplish your goal via the current build step, or if that framework solves anything for you, in which case feel free to throw that into this PR maybe? Happy either way! (CC @danitt for your thoughts on whether that's theoretically wise.) |
I'm happy to attempt porting the framework before @Rupert28 gets too far into this pr (especially because Zen browser is slowly becoming my fav browser .. and it's built on FF engine) |
|
A framework definitely seems like a good idea! I probably should've considered that lol. After a quick google I found wxt.dev, which supports more browsers than CRXJS (Chrome, Firefox, Edge, Safari, Chromium-based browsers). Would that one be a better choice? That way we could port to a framework and add FF (and a bunch of other) support in one go! Zen is also becoming my favourite browser too except for it stealing waaayyy too much RAM... Edit: I'm happy to have a go migrating to WXT if that's the way you guys want to go. I'd probs do it in a seperate PR and close this off just for consistency |
at a cursory glance both CRXJS and WXT look decent (solid stack, healthy contribution history, good docs), but due to the browser suppoort WXT might be a nicer way to go. I'll have a closer look later - good suggestion @Rupert28 🔥 |
|
In favour of wider distribution as long as DX remains comfortable for contributors! |
|
hey all, happy to report the migration effort to wxt is mostly done and looking pretty darn good 🎉 everything lints, compiles, and statically looks more or less correct, but I've yet to do any runtime testing - anyone willing to jump and verify / fix the remaining bits would be more than welcome 🙏🏻 |
Begun work on modifying build so it works on Firefox-based browsers.
scriptsarray must be passed.Will hopefully be able to work on this further.