feat: Add Phone Number Plugin field support.#74
Open
quangbahoa wants to merge 1 commit into
Open
Conversation
Support for phoneNumber field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PhoneNumber Field Type Support for payload-phone-number-plugin
Problem
When using
payload-phone-number-pluginwithpayload-oapi, the OpenAPI spec generation fails with the error:This occurs because
payload-phone-number-plugincreates a custom field typePhoneNumberthatpayload-oapidoesn't recognize when processing JSON schema references.Solution
Add support for the
PhoneNumbercustom field type by:generateComponents()functionadjustRefTargets()functionChanges Required
1. File:
src/openapi/generators.ts(or equivalent TypeScript source)Add helper function to check for PhoneNumber references:
In
generateComponents()function:Conditionally add PhoneNumber schema only if it's actually used:
In
adjustRefTargets()function:Add handling for PhoneNumber reference before checking collections:
Testing
payload-phone-number-pluginin a Payload CMS projectphoneNumberFieldto a collectionphoneNumberfield appears in OpenAPI spec as a string withformat: 'tel'Benefits
phoneNumberFieldfrompayload-phone-number-pluginsupportedTimezoneshandlingRelated
payload-phone-number-plugin(https://github.com/your-repo/payload-phone-number-plugin)Notes
This fix can be extended to support other custom field types from plugins by following the same pattern:
generateComponents()adjustRefTargets()