Add -min-trigger-time to delay installing breakpoint
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows capturing traces with `-trigger` symbols that get called with very high (possibly bursty) frequency, where we otherwise migt trigger before the snapshot buffer has a chance to fill up. Closes janestreet#56. Signed-off-by: Tudor Brindus <[email protected]>
cgaebel
approved these changes
Apr 20, 2022
Contributor
cgaebel
left a comment
cgaebel
left a comment
There was a problem hiding this comment.
LGTM. Consider leaving something in the FAQ pointing people to this solution. You don't actually have to do it, I am literally asking you to consider it.
|
Hi @Xyene, do these changes still work? I needed this feature for a project, so I tried copying its changes to a local clone (magic-trace version 1.2.1) but got this error while building:
I am not familiar enough with OCaml to understand how to resolve the 2nd error. Is it fixable? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows capturing traces with
-triggersymbols that get calledwith very high (possibly bursty) frequency, where we otherwise migt
trigger before the snapshot buffer has a chance to fill up.
Closes #56.
Signed-off-by: Tudor Brindus [email protected]