Snapshot using perf ctlfd #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnbrks
force-pushed
the
use-perf-controlfd
branch
from
06c7943 to
3011cd4
Compare
Signed-off-by: Ilana Brooks <[email protected]>
lnbrks
force-pushed
the
use-perf-controlfd
branch
from
3011cd4 to
a66e21b
Compare
Xyene
reviewed
Apr 12, 2025
| @@ -0,0 +1,80 @@ | |||
| open Core | |||
There was a problem hiding this comment.
Suggested change
| open Core | |
| open! Core |
|
|
||
| let close_perf_side_fds t = | ||
| Core_unix.close ~restart:true t.ctl_rx; | ||
| t.ctl_rx <- Core_unix.File_descr.of_int (-1); |
| if should_take_snapshot | ||
| then ( | ||
| match t.snapshot_behavior with | ||
| | Never -> failwith "unreachable" |
There was a problem hiding this comment.
Suggestion: lift this block into a let snapshot () = ..., then have the -> (true|false) branches above be -> (() | snapshot ()). That way we don't have to double-state the Never case.
| (String.equal | ||
| ack_msg | ||
| (Bytes.unsafe_to_string ~no_mutation_while_string_reachable:t.ack_buf)) | ||
| then failwith "Receive malformed ack from perf"; |
There was a problem hiding this comment.
This will be very hard to debug if it ever raises. Let's turn this into a raise_s and include the ack we did get.
| else ( | ||
| match when_to_snapshot with | ||
| | Magic_trace_or_the_application_terminates -> | ||
| if perf_supports_snapshot_on_exit then `at_exit `sigint else `at_exit `sigusr2 | ||
| | Application_calls_a_function _ -> `function_call) | ||
| if perf_supports_snapshot_on_exit then At_exit Sigint else At_exit Sigusr2 |
There was a problem hiding this comment.
Can we use the ctrlfd here too?
This logic is also used for triggering on ^C; it'd be nice to get away from the buggy signal handling where we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.