Skip to content

feat(desktop): add category for linux build#8113

Open
xuars wants to merge 1 commit into
janhq:mainfrom
xuars:category
Open

feat(desktop): add category for linux build#8113
xuars wants to merge 1 commit into
janhq:mainfrom
xuars:category

Conversation

@xuars
Copy link
Copy Markdown

@xuars xuars commented May 3, 2026

Describe Your Changes

  • Adds the category entry to the Linux .desktop file, for use in desktop environments with a categorized application menu.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Additional information

https://v2.tauri.app/reference/config/#category

@tokamak-pm
Copy link
Copy Markdown

tokamak-pm Bot commented May 4, 2026

Code Review

Summary: Adds a "category": "Utility" field to tauri.conf.json so the Linux .desktop file includes an application category. This ensures Jan appears under the correct menu group in desktop environments that use freedesktop categories (GNOME, KDE, XFCE, etc.).

Findings:

  • Change is minimal and correct. One line added, trailing comma fixed on the previous line. JSON structure is valid.
  • "Utility" is a reasonable category for an AI assistant/chat desktop app per the freedesktop.org menu spec. Utility maps to "Accessories" in most desktop environments. An alternative like Science or Education could also work depending on positioning, but Utility is a safe default.
  • Tauri docs confirm the category field maps directly to the .desktop Categories= entry on Linux (reference).
  • No CI runs visible beyond the Tokamak check (neutral). Since this is a config-only change with no code logic, the risk is negligible.
  • No tests needed — this is a declarative config change.

Recommendation: can merge

Clean, low-risk change that improves Linux desktop integration.

@tokamak-pm
Copy link
Copy Markdown

tokamak-pm Bot commented Jun 3, 2026

Follow-up review (new activity detected)

Since our last review (2026-05-04), the single commit was amended (committer date changed from 2026-05-03 to 2026-05-05), but the actual code change is identical -- still a one-line addition of "category": "Utility" to src-tauri/tauri.conf.json.

No new discussion or substantive changes. Our original assessment stands: this is a clean, minimal, correct config change that improves Linux desktop integration.

Recommendation: can merge

@mbugni
Copy link
Copy Markdown

mbugni commented Jun 6, 2026

If not a bug, this could be considered a cosmetic issue. Look at how it appears on a modern Linux desktop:

jan_menu

In italian, "oggetti smarriti" means "lost objects", essentially trash.

@tokamak-pm
Copy link
Copy Markdown

tokamak-pm Bot commented Jun 7, 2026

Follow-up -- responding to @mbugni's feedback.

Good catch. The screenshot shows that Utility maps to "Accessories" in English desktop environments, but in some locales (Italian in this case) it gets translated to an unflattering label ("oggetti smarriti" / "lost objects"). This is a real UX concern worth addressing before merging.

Looking at the Tauri category enum values, better alternatives for an AI chat/assistant app would be:

  • "Productivity" -- maps to freedesktop Office category. Jan is a productivity tool for working with LLMs, so this is arguably the best fit. Shows up as "Office" or equivalent in most desktop menus.
  • "Education" -- maps to Education. Reasonable if Jan is positioned as a learning/research tool.
  • "DeveloperTool" -- maps to Development. Could work given Jan's technical user base, but too narrow.

I'd recommend @xuars change the value to "Productivity" -- it's the most accurate descriptor for an AI assistant desktop app and avoids the poor menu placement @mbugni identified.

Updated recommendation: request changes -- switch "Utility" to "Productivity" before merging.

@mbugni
Copy link
Copy Markdown

mbugni commented Jun 7, 2026

No, the screenshot shows that the current lack of classification forces the desktop environment to associate a default classification called "lost object." If the classification proposed by this PR were applied, the app would be included in the "Utility" menu, which is much more meaningful. Therefore this PR, or a better classification, should be applied immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants