fix(i18n): complete and improve German (de-DE) provider translations#8284
fix(i18n): complete and improve German (de-DE) provider translations#8284tobiasheinrichfaska wants to merge 3 commits into
Conversation
Replace "Anbieter" with the loanword "Provider" (matches the term used
across the German UI) and capitalize the informal address ("Deinen").
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR Review: fix(i18n): complete and improve German (de-DE) provider translationsSummaryThis PR updates
Translation Quality AssessmentGood:
Issues Found1. Terminology inconsistency: "Provider" vs. "Anbieter" (medium severity) The PR switches from "Anbieter" to the English loanword "Provider" in this file (commit 2 message explains this was intentional). However, every other German locale file in the codebase uses "Anbieter" consistently:
This means the same concept will appear as both "Provider" and "Anbieter" in different parts of the German UI. For example, Recommendation: Either (a) revert to "Anbieter" in this file to stay consistent with the rest of the codebase, or (b) plan a follow-up PR that migrates all other de-DE files to "Provider" as well. Option (a) is simpler and safer for now. 2. Note on duplicate keys across files (informational, not caused by this PR) The keys 3. Capitalization of informal address "Du/dein" (minor, non-blocking) The PR uses capitalized "Deinen" in Final Recommendation: improve neededThe translations themselves are high quality, and the addition of 9 missing keys is valuable. However, the "Anbieter" to "Provider" terminology switch introduces an inconsistency with the rest of the German locale. I would suggest reverting to "Anbieter" in this file to maintain consistency with Once the terminology is aligned, this is ready to merge. |
Revert the earlier Anbieter->Provider switch. Every other locale localizes "provider" to its native word (fr fournisseur, es proveedor, it fornitore, …) and all other de-DE files use "Anbieter"; keeping the loanword made German the lone outlier. Addresses review feedback on janhq#8284. (Keeps the capital-"Du" fix.) Each change reviewed and approved by the contributor (native German speaker) before commit; AI-assisted. Signed-off-by: Tobias Heinrich <tobias.a.w.heinrich@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Completes and improves the German (de-DE) translation of
web-app/src/locales/de-DE/provider.json. Part of #8221.Changes
addOpenAIProvider: „OpenAI Anbieter hinzufügen" → „Benutzerdefinierten Anbieter hinzufügen" (EN is now "Add Custom Provider").enterNameForProvider: generic label → placeholder with example, matching current EN.Testing
JSON validated (parses; key order matches
en/provider.json). No missing keys remain for this file.Note on screenshots
The contributing guide asks for a screenshot. This PR only edits a locale JSON file (no layout or logic change). As a free-time contributor on my personal device, I deliberately did not install and build the full app for security reasons, so I can't provide a running-app screenshot. Happy to coordinate if a maintainer wants to verify in-app.