fix(phel): suite-compat patches for nightly run#899
Merged
Conversation
Three small :phel reader-conditional fixes so the suite stays green when run under phel-lang's nightly CI: * add_watch.cljc — phel-lang renamed Phel.Lang.ExInfoException to Phel.Lang.ExceptionInfo. Update the :phel branch of the catch. * group_by.cljc — phel does not propagate metadata through group-by. Skip the metadata testing block for :phel. * repeatedly.cljc — phel's analyser-level ConstantFolder evaluates (repeatedly identity) at compile time, calling identity with zero args; the file fails to compile. Skip the "is lazy" single-arg subtest for :phel until the folder is taught not to invoke runtime-throwing calls. Other dialects unchanged.
This was referenced May 27, 2026
Closed
Chemaclass
added a commit
to phel-lang/phel-lang
that referenced
this pull request
May 27, 2026
Without this, the main/nightly suite run goes red and stays red until jank-lang/clojure-test-suite#899 lands and the phel-side ConstantFolder bug around (repeatedly identity) is fixed. Soft-gate keeps the signal visible (job still runs, results still shown) without painting the main-branch CI red. Drop this once the suite is green against pure upstream.
Chemaclass
added a commit
to phel-lang/phel-lang
that referenced
this pull request
May 27, 2026
* ci(clojure-test-suite): drop pull_request trigger; main + nightly only Running the suite on every PR meant suite-breakage (currently from a phel-side ConstantFolder bug around (repeatedly identity), tracked as :phel patches at jank-lang/clojure-test-suite#899) blocks unrelated work like #2202. Suite drift is caught by the daily cron and any push to main, which is the level of gating Phel actually needs. Per-PR can come back once the suite is reliably green against pure upstream. Manual run still available via workflow_dispatch. * ci(clojure-test-suite): re-add continue-on-error for main + nightly Without this, the main/nightly suite run goes red and stays red until jank-lang/clojure-test-suite#899 lands and the phel-side ConstantFolder bug around (repeatedly identity) is fixed. Soft-gate keeps the signal visible (job still runs, results still shown) without painting the main-branch CI red. Drop this once the suite is green against pure upstream.
E-A-Griffin
approved these changes
May 27, 2026
Collaborator
E-A-Griffin
left a comment
E-A-Griffin
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Contributor
Author
|
Tracking upstream phel-lang core bugs surfaced by this nightly run:
Once #2210 lands the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small
:phelreader-conditional fixes so the suite stays green under phel-lang's nightly CI. Other dialects unchanged.Changes
add_watch.cljc— phel-lang renamedPhel.Lang.ExInfoExceptiontoPhel.Lang.ExceptionInfo(phel-lang/phel-lang#2006). Update the:phelbranch of the catch so the test stops aborting the run mid-suite.group_by.cljc— phel does not propagate metadata throughgroup-by. Skip the metadata testing block for:phel(same pattern used by other dialects with known divergences).repeatedly.cljc— phel's analyser-levelConstantFolderevaluates(repeatedly identity)at compile time, callingidentitywith zero args; the file fails to compile. Skip the "is lazy" single-arg subtest for:pheluntil the folder is taught not to invoke runtime-throwing calls.Context
The
phel-lang/clojure-test-suitefork was carrying these patches locally, which forced ongoing divergence from upstream. After phel-lang/clojure-test-suite#15 and a sync, the fork now mirrorsjank-lang/clojure-test-suiteexactly — but the Phel nightly suite job depends on these:phelbranches to stay green.Upstreaming them keeps the fork a pure mirror and avoids per-dialect patch drift.