Add unicode char tests#904
Conversation
| (is #?(:lpy (not (p/lazy-seq? s)) | ||
| :default (p/lazy-seq? s))) | ||
| (is #?(:lpy true | ||
| :default (not (realized? s)))) |
There was a problem hiding this comment.
These were failing for me locally and annoying me so just fixed them as part of this work, can separate this to a different PR if need be
There was a problem hiding this comment.
The fix for this was already merged into Basilisp's main branch, so you probably are not on the latest commit.
In the future, I would prefer if you either made sure you were up to date or just didn't run the tests locally at all.
cc @jeaye
There was a problem hiding this comment.
Ok, yeah. Thanks for trying to keep up on the different dialects, Emma. It's too much to juggle, though, so we should just focus on the CI jobs that we're running and let dialect devs deal with everything else.
| (is (= \ষ (char 2487)))) | ||
| (testing "4+ byte characters throw" | ||
| (is #?(:jank (= (first "𐅦") (char 65895)) | ||
| ;; this seems to be an off by one error |
There was a problem hiding this comment.
Is this a Basilisp bug? Shall we ping Chris?
There was a problem hiding this comment.
This function delegates directly to Python chr. Are you sure Basilisp is the one in error?
|
Thanks, Emma! |
3 participants
This closes #799