Add P2P transport protocol version in peers list + summary card#683
Open
0xf0xx0 wants to merge 3 commits into
Open
Add P2P transport protocol version in peers list + summary card#6830xf0xx0 wants to merge 3 commits into
0xf0xx0 wants to merge 3 commits into
Conversation
Contributor
|
That's great, thanks! |
0xf0xx0
force-pushed
the
v2-or-not-v2
branch
from
November 10, 2024 00:48
8ffb381 to
53010c1
Compare
Contributor
Author
|
better commit message |
Contributor
|
One minor note: I notice from your screenshot that the new column is very wide, caused by the title "trans. protocol". By picking a shorter title (e.g. just "P2P") we'd save horizontal space. |
Contributor
Author
|
youre right, P2P is much better. also added a tooltip for clarity uwu |
0xf0xx0
force-pushed
the
v2-or-not-v2
branch
from
November 10, 2024 15:25
53010c1 to
6f5cb67
Compare
Contributor
Author
|
i was able to stuff in the transport protocol summary too :3 |
Jacksonearl2468
approved these changes
Nov 10, 2024
Jacksonearl2468
approved these changes
Nov 10, 2024
0xf0xx0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #628
@schildbach hows this?