Fix SNMPv3 credential handling - #80
Open
triantos wants to merge 1 commit into
Open
Conversation
Create a dedicated PySNMP engine for each config entry so credentials for the same SNMPv3 username do not collide across devices. Treat an empty privacy key as unset so AuthNoPriv configurations work with current PySNMP releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None.Problem
Home Assistant's shared SNMP engine can retain USM credentials by security
name. When multiple devices use the same SNMPv3 username with different
authentication or privacy settings, their credentials can collide.
Additionally, the config flow stores the optional privacy key as an empty
string for AuthNoPriv configurations. Current PySNMP releases validate that
empty string as a privacy key and reject it for being too short, even though
privacy is disabled.
Testing
Tested with:
Before this change, setup failed with a PySNMP USM
WrongValueError.Afterward, the config entry loads and its entities update normally.
python3 -m compileall -q custom_componentsandgit diff --checkboth pass.